Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed device missing from traps/new Log::event() #9963

Merged
merged 3 commits into from Mar 16, 2019

Conversation

murrant
Copy link
Member

@murrant murrant commented Mar 15, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

TheGreatDoc
TheGreatDoc previously approved these changes Mar 15, 2019
Copy link
Contributor

@TheGreatDoc TheGreatDoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + Tested

@TheGreatDoc
Copy link
Contributor

Oh, well, travis complains about it. Im not going to merge until you check and approve it

@murrant
Copy link
Member Author

murrant commented Mar 16, 2019

Done now :)

Copy link
Contributor

@TheGreatDoc TheGreatDoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheGreatDoc TheGreatDoc merged commit 3825133 into librenms:master Mar 16, 2019
@laf laf changed the title Fix device missing from traps/new Log::event() Fixed device missing from traps/new Log::event() Mar 31, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
@murrant murrant deleted the fix-event-log branch September 30, 2019 15:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants